-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Bad Cards #46
base: dev
Are you sure you want to change the base?
All Bad Cards #46
Conversation
|
|
cf540db
to
11468cf
Compare
Ok, I deleted this branch and pushed up a second attempt. I think the host is creating the game correctly with url call that looks like
but when the other players attempt to navigate to
they get |
Good catch - there was a bug upon joining a created game, which should be fixed now! |
Hey Jake, sorry for the delay again, I was focused on Drawphone. So I've added all three of your games in that last commit. The url from before didn't seem to be working, so I removed the Let me know if you need any more info. The recent changes to the your site look really nice, Good work!!!! 😄 |
is this fixed? i havent checked, yet so apologies if it is. looking to get these new games merged soon. ive been putting it off for long enough!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add BGG IDs.
basedOn: { | ||
game: "Cards Against Humanity", | ||
link: "https://cardsagainsthumanity.com/", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | |
bggId: 50381, | |
}, |
game: "Apples to Apples", | ||
link: | ||
"https://www.mattelgames.com/games/en-us/family/apples-apples", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | |
bggId: 74, | |
}, |
@jakelauer
With this code, users will end up in the same all bad cards room, but will have some weird errors and the game won't work. 🤔 ❤️